Code quality

ALN** occurrences by order of importance

NOQA	Number of occurrences
ALN069: You can't import models from other components, see: https://www.notion.so/alaninsurance/Modular-monolith-a9d84f1318d34115bbd08b3648e5a587 ⧉",	29
ALN043: You can only import things from a Component public module, see: https://www.notion.so/alaninsurance/Modular-monolith-a9d84f1318d34115bbd08b3648e5a587 ⧉",	59
ALN039: The module public cannot import other components (or from apps/), it's meant to be the public interface of the component #{self.component_name}, see: https://www.notion.so/alaninsurance/Modular-monolith-a9d84f1318d34115bbd08b3648e5a587 ⧉",	1

Listing of files of the most critical ALN**

ALN069 occurs 29 times

File:line	Content
components/pet/internal/commands/migrate_waitlist_data.py:496 ⧉	from components.gamification.internal.models.walk_feedback import ( # noqa: ALN069
components/pet/internal/commands/migrate_waitlist_data.py:618 ⧉	from components.gamification.internal.models.walk_feedback import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:46 ⧉	from components.contracting.subcomponents.contract.internal.models.contract import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:49 ⧉	from components.contracting.subcomponents.contract.internal.models.contract_enrollment_module import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:52 ⧉	from components.contracting.subcomponents.contract.internal.models.contract_version import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:55 ⧉	from components.contracting.subcomponents.proposal.internals.models.approval_request import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:58 ⧉	from components.contracting.subcomponents.proposal.internals.models.proposal import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:61 ⧉	from components.contracting.subcomponents.proposal.internals.models.proposal_error import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:64 ⧉	from components.contracting.subcomponents.proposal.internals.models.proposal_item import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:67 ⧉	from components.contracting.subcomponents.proposal.internals.models.proposal_item_target import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:70 ⧉	from components.contracting.subcomponents.proposal.v2.internal.models.contracting_change_module import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:73 ⧉	from components.contracting.subcomponents.subscription.internal.models.subscription import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:76 ⧉	from components.contracting.subcomponents.subscription.internal.models.subscription_version import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:79 ⧉	from components.core_enrollment.internal.models.enrollment_group import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:82 ⧉	from components.core_enrollment.internal.models.enrollment_group_revision import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:85 ⧉	from components.core_enrollment.internal.models.enrollment_period import ( # noqa: ALN069
components/pet/internal/commands/nuke_user_pet_data.py:91 ⧉	from components.member_lifecycle.subcomponents.add_dependents.internal.models.dependent_draft import ( # noqa: ALN069
components/pet/internal/commands/simulate_pet_signature_callback.py:49 ⧉	from components.contracting.subcomponents.legal_document.internal.models.legal_document import ( # noqa: ALN069
components/pet/internal/commands/simulate_pet_signature_callback.py:55 ⧉	from components.contracting.subcomponents.proposal.internals.models.approval_request import ( # noqa: ALN069
components/pet/internal/commands/tests/test_nuke_user_pet_data.py:12 ⧉	from components.member_lifecycle.subcomponents.add_dependents.internal.models.dependent_draft import ( # noqa: ALN069
components/pet/internal/controllers/waitlist.py:88 ⧉	from components.fr.internal.models.user import User # noqa: ALN069
components/pet/internal/controllers/waitlist.py:114 ⧉	from components.fr.internal.models.user import User # noqa: ALN069
components/pet/internal/controllers/waitlist.py:133 ⧉	from components.fr.internal.models.user import User # noqa: ALN069
components/pet/internal/controllers/waitlist.py:174 ⧉	from components.fr.internal.models.user import User # noqa: ALN069
components/pet/internal/controllers/policies.py:23 ⧉	from components.fr.internal.models.user import User # noqa: ALN069
components/pet/internal/controllers/pets.py:37 ⧉	from components.fr.internal.models.user import User # noqa: ALN069
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:247 ⧉	from components.contracting.subcomponents.legal_document.internal.models.legal_document import ( # noqa: ALN069
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:253 ⧉	from components.contracting.subcomponents.proposal.internals.models.proposal import ( # noqa: ALN069
components/pet/internal/business_logic/tests/test_dispatch_v2_pipeline_e2e.py:206 ⧉	from components.contracting.subcomponents.proposal.internals.models.proposal import ( # noqa: ALN069

ALN043 occurs 59 times

File:line	Content
components/pet/internal/commands/simulate_pet_signature_flow.py:64 ⧉	from components.insurance_plan_catalog.internal.product_custom_data.pet_insurance.factory import ( # noqa: ALN043
components/pet/internal/commands/simulate_pet_signature_callback.py:58 ⧉	from components.contracting.subcomponents.proposal.v2.internal.command_handlers.approve_contracting_package_command_handler import ( # noqa: ALN043
components/pet/internal/commands/simulate_pet_signature_callback.py:61 ⧉	from components.contracting.subcomponents.proposal.v2.internal.command_handlers.update_signature_command_handler import ( # noqa: ALN043
components/pet/internal/commands/simulate_pet_signature_callback.py:64 ⧉	from components.contracting.subcomponents.proposal.v2.internal.commands.approve_contracting_package_command import ( # noqa: ALN043
components/pet/internal/commands/simulate_pet_signature_callback.py:67 ⧉	from components.contracting.subcomponents.proposal.v2.internal.commands.update_signature_command import ( # noqa: ALN043
components/pet/internal/commands/tests/test_nuke_user_pet_data.py:9 ⧉	from components.member_lifecycle.subcomponents.add_dependents.internal.dependent_draft.actions import ( # noqa: ALN043
components/pet/internal/controllers/tests/test_pet_documents.py:5 ⧉	from components.fr.internal.tests.factories.user import ( # noqa: ALN043
components/pet/internal/controllers/tests/test_pets.py:12 ⧉	from components.fr.internal.tests.factories.user import ( # noqa: ALN043
components/pet/internal/controllers/tests/test_waitlist.py:9 ⧉	from components.fr.internal.tests.factories.user import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:37 ⧉	from components.insurance_plan_catalog.internal.product_custom_data.pet_insurance.factory import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:165 ⧉	from components.contracting.subcomponents.proposal.v2.internal.command_handlers.approve_contracting_package_command_handler import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:168 ⧉	from components.contracting.subcomponents.proposal.v2.internal.commands.approve_contracting_package_command import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:216 ⧉	from components.contracting.subcomponents.proposal.v2.internal.repositories.approval_request_repository import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:258 ⧉	from components.contracting.internal.enums.contractee_segment import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:264 ⧉	from components.contracting.subcomponents.proposal.api.entities.approval_request import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:267 ⧉	from components.contracting.subcomponents.proposal.api.entities.proposal_origin import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:270 ⧉	from components.contracting.subcomponents.proposal.v2.internal.command_handlers.create_contracting_package_command_handler import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:273 ⧉	from components.contracting.subcomponents.proposal.v2.internal.command_handlers.finalize_contracting_package_command_handler import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:276 ⧉	from components.contracting.subcomponents.proposal.v2.internal.command_handlers.request_approval_command_handler import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:279 ⧉	from components.contracting.subcomponents.proposal.v2.internal.commands.create_contracting_change_command import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:282 ⧉	from components.contracting.subcomponents.proposal.v2.internal.commands.create_contracting_change_module_command import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:285 ⧉	from components.contracting.subcomponents.proposal.v2.internal.commands.create_contracting_change_target_command import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:288 ⧉	from components.contracting.subcomponents.proposal.v2.internal.commands.create_contracting_package_command import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:291 ⧉	from components.contracting.subcomponents.proposal.v2.internal.commands.finalize_contracting_package_command import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:294 ⧉	from components.contracting.subcomponents.proposal.v2.internal.commands.request_approval_command import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:297 ⧉	from components.contracting.subcomponents.proposal.v2.internal.entities.contracting_change_configuration import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:300 ⧉	from components.contracting.subcomponents.proposal.v2.internal.entities.signer_details import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:303 ⧉	from components.contracting.subcomponents.proposal.v2.internal.enums.field_name import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:306 ⧉	from components.contracting.subcomponents.proposal.v2.internal.providers.contracting_change_initialization_context import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet.py:348 ⧉	# (per @jsagl, PR #90810 review). Drives all the ALN043 noqas below.
components/pet/internal/business_logic/enroll_pet_after_contract_creation.py:26 ⧉	from components.core_enrollment.external.adapters.pet import ( # noqa: ALN043
components/pet/internal/business_logic/enroll_pet_after_contract_creation.py:29 ⧉	from components.core_enrollment.external.adapters.profile import ( # noqa: ALN043
components/pet/internal/business_logic/owner_id.py:19 ⧉	# core_enrollment.external.UserIdMapping (lets us drop the ALN043 noqa).
components/pet/internal/business_logic/owner_id.py:20 ⧉	from components.core_enrollment.external.adapters.user_id_mapping import ( # noqa: ALN043
components/pet/internal/business_logic/tests/conftest.py:15 ⧉	from components.core_enrollment.bootstrap.load_all_models import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:58 ⧉	from components.contracting.internal.enums.contractee_segment import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:64 ⧉	from components.contracting.subcomponents.proposal.v2.internal.country_specific.fr.configurations.fr_approval_request_configuration import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:67 ⧉	from components.contracting.subcomponents.proposal.v2.internal.country_specific.fr.configurations.fr_contracting_package_configuration import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:70 ⧉	from components.contracting.subcomponents.proposal.v2.internal.country_specific.fr.configurations.fr_pet_insurance_subscription import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:73 ⧉	from components.contracting.subcomponents.proposal.v2.internal.entities.approval_request_configuration import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:76 ⧉	from components.contracting.subcomponents.proposal.v2.internal.entities.contracting_change_configuration import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:80 ⧉	from components.contracting.subcomponents.proposal.v2.internal.entities.contracting_package_configuration import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:256 ⧉	from components.contracting.subcomponents.proposal.v2.internal.command_handlers.approve_contracting_package_command_handler import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:259 ⧉	from components.contracting.subcomponents.proposal.v2.internal.command_handlers.update_signature_command_handler import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:262 ⧉	from components.contracting.subcomponents.proposal.v2.internal.commands.approve_contracting_package_command import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:265 ⧉	from components.contracting.subcomponents.proposal.v2.internal.commands.update_signature_command import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:268 ⧉	from components.contracting.subcomponents.proposal.v2.internal.repositories.approval_request_repository import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:271 ⧉	from components.contracting.subcomponents.proposal.v2.internal.repositories.contracting_package_repository import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_pet_signature_chain_e2e.py:279 ⧉	from components.insurance_plan_catalog.internal.product_custom_data.pet_insurance.factory import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_dispatch_v2_pipeline_e2e.py:55 ⧉	from components.contracting.internal.enums.contractee_segment import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_dispatch_v2_pipeline_e2e.py:61 ⧉	from components.contracting.subcomponents.proposal.v2.internal.country_specific.fr.configurations.fr_approval_request_configuration import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_dispatch_v2_pipeline_e2e.py:64 ⧉	from components.contracting.subcomponents.proposal.v2.internal.country_specific.fr.configurations.fr_contracting_package_configuration import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_dispatch_v2_pipeline_e2e.py:67 ⧉	from components.contracting.subcomponents.proposal.v2.internal.country_specific.fr.configurations.fr_pet_insurance_subscription import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_dispatch_v2_pipeline_e2e.py:70 ⧉	from components.contracting.subcomponents.proposal.v2.internal.entities.approval_request_configuration import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_dispatch_v2_pipeline_e2e.py:73 ⧉	from components.contracting.subcomponents.proposal.v2.internal.entities.contracting_change_configuration import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_dispatch_v2_pipeline_e2e.py:77 ⧉	from components.contracting.subcomponents.proposal.v2.internal.entities.contracting_package_configuration import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_dispatch_v2_pipeline_e2e.py:209 ⧉	from components.contracting.subcomponents.proposal.v2.internal.repositories.approval_request_repository import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_dispatch_v2_pipeline_e2e.py:212 ⧉	from components.contracting.subcomponents.proposal.v2.internal.repositories.contracting_package_repository import ( # noqa: ALN043
components/pet/internal/business_logic/tests/test_dispatch_v2_pipeline_e2e.py:242 ⧉	from components.insurance_plan_catalog.internal.product_custom_data.pet_insurance.factory import ( # noqa: ALN043

ALN039 occurs 1 times

File:line	Content
components/pet/internal/business_logic/owner_id.py:7 ⧉	importing ``core_enrollment.external`` directly (ALN039).