Code quality

ALN** occurrences by order of importance¶

NOQA	Number of occurrences
ALN069: You can't import models from other components, see: https://www.notion.so/alaninsurance/Modular-monolith-a9d84f1318d34115bbd08b3648e5a587 ⧉",	13
ALN043: You can only import things from a Component `public` module, see: https://www.notion.so/alaninsurance/Modular-monolith-a9d84f1318d34115bbd08b3648e5a587 ⧉",	50
ALN039: The module `public` cannot import other components (or from `apps/`), it's meant to be the public interface of the component #{self.component_name}, see: https://www.notion.so/alaninsurance/Modular-monolith-a9d84f1318d34115bbd08b3648e5a587 ⧉",	13
ALN009: Checks that models do not import business logic	1
ALN037: @property are not serialized by dataclass_json. If not a problem for your use case, please ignore (# noqa: ALN037). "See this Notion page: https://www.notion.so/alaninsurance/Dataclass-the-good-parts-8f387ec2a8e24a55af294237b97dc210#a611a9154af448a38e552c61415169df ⧉	1
ALN071: SQLAlchemy v2 migration, in models all attributes (or functions with `@declared_attr`) must return a `Mapped[...]` type. If it's a class variable type it with `ClassVar[...]`	2
ALN077: Check for usage of backref in SQLAlchemy relationships and suggest using back_populates instead.	20
ALN085: Enforces SQLAlchemy 2.0 query style by detecting deprecated patterns that will be removed in SQLAlchemy 2.0. This linter checks for: 1. Usage of session.query() which is deprecated in favor of session.scalar(), session.scalars(), or session.execute() Note: Other SQLAlchemy 2.0 deprecation warnings are already being turned into errors at runtime by the _turn_sql_alchemy_warning_into_errors function in backend/shared/models/orm/sqlalchemy.py.	148

Listing of files of the most critical ALN**¶

ALN069 occurs 13 times¶

File:line	Content
components/customer_health_partner/credits/external/employees_count.py:16 ⧉	`from components.fr.internal.models.account import ( # noqa: ALN069`
components/customer_health_partner/credits/external/employees_count.py:19 ⧉	`from components.fr.internal.models.company import ( # noqa: ALN069`
components/customer_health_partner/credits/public/commands/reset_all_credit_counts.py:47 ⧉	`from components.fr.internal.models.company import Company # noqa: ALN069`
components/customer_health_partner/credits/public/commands/reset_all_credit_counts.py:48 ⧉	`from components.fr.internal.models.employment import Employment # noqa: ALN069`
components/customer_health_partner/public/controllers/tests/test_account.py:6 ⧉	`from components.be.internal.models.tests.factories import ( # noqa: ALN039,ALN069`
components/customer_health_partner/public/controllers/tests/test_account.py:9 ⧉	`from components.es.internal.models.tests.factories import ( # noqa: ALN039,ALN069`
components/customer_health_partner/public/business_logic/actions/create_demo_admin_health_partner_features.py:7 ⧉	`from components.fr.internal.models.account import ( # noqa: ALN039,ALN069`
components/customer_health_partner/public/business_logic/actions/create_demo_admin_health_partner_features.py:10 ⧉	`from components.fr.internal.models.user import ( # noqa: ALN039,ALN069`
components/customer_health_partner/wellbeing_assessment/public/commands/tests/test_wellbeing_assessment.py:5 ⧉	`from components.be.internal.models.tests.factories import ( # noqa: ALN069 # - tests`
components/customer_health_partner/wellbeing_assessment/public/commands/tests/test_wellbeing_assessment.py:22 ⧉	`from components.es.internal.models.tests.factories import ( # noqa: ALN069 # - tests`
components/customer_health_partner/wellbeing_assessment/public/commands/tests/test_common.py:5 ⧉	`from components.be.internal.models.tests.factories import ( # noqa: ALN069 # - tests`
components/customer_health_partner/wellbeing_assessment/public/commands/tests/test_common.py:38 ⧉	`from components.es.internal.models.tests.factories import ( # noqa: ALN069 # - tests`
components/customer_health_partner/internal/business_logic/queries/customer_priorities_survey.py:26 ⧉	`from components.fr.internal.models.account import ( # noqa: ALN069`

ALN043 occurs 50 times¶

File:line	Content
components/customer_health_partner/external/authorization.py:40 ⧉	`from components.fr.internal.controllers.account import ( # noqa: ALN043`
components/customer_health_partner/external/authorization.py:72 ⧉	`from components.fr.internal.business_logic.account.queries.account import ( # noqa: ALN043`
components/customer_health_partner/external/authorization.py:75 ⧉	`from components.fr.internal.business_logic.company.queries.admin import ( # noqa: ALN043`
components/customer_health_partner/external/user.py:28 ⧉	`from components.fr.internal.business_logic.user.queries.user import ( # noqa: ALN043`
components/customer_health_partner/external/user.py:58 ⧉	`from components.fr.internal.business_logic.user.queries.user import ( # noqa: ALN043`
components/customer_health_partner/external/user.py:96 ⧉	`from components.fr.internal.business_logic.user.queries.user import ( # noqa: ALN043`
components/customer_health_partner/external/user.py:120 ⧉	`from components.global_customer_dashboard.external.queries.admined_entities import ( # noqa: ALN043 # Waiting for better public API`
components/customer_health_partner/external/company_ids_for_account.py:16 ⧉	`from components.fr.internal.business_logic.customer_health_partner.wellbeing_assessment.get_company_ids_for_account_company_ids import ( # noqa: ALN043`
components/customer_health_partner/external/account.py:81 ⧉	`from components.fr.internal.business_logic.company.queries.admin import ( # noqa: ALN043`
components/customer_health_partner/external/account.py:163 ⧉	`from components.fr.internal.business_logic.company.queries.company import ( # noqa: ALN043`
components/customer_health_partner/external/company.py:24 ⧉	`from components.fr.internal.business_logic.global_customer_dashboard.customer_health_partner import ( # noqa: ALN043`
components/customer_health_partner/external/company.py:56 ⧉	`from components.fr.internal.business_logic.global_customer_dashboard.customer_health_partner import ( # noqa: ALN043`
components/customer_health_partner/external/company.py:89 ⧉	`from components.fr.internal.mind.business_logic.queries.company import ( # noqa: ALN043`
components/customer_health_partner/external/company.py:131 ⧉	`from components.fr.internal.business_logic.company.queries.company import ( # noqa: ALN043`
components/customer_health_partner/external/company.py:170 ⧉	`from components.fr.internal.business_logic.company.queries.company import ( # noqa: ALN043`
components/customer_health_partner/external/company.py:204 ⧉	`from components.fr.internal.business_logic.global_customer_dashboard.customer_health_partner import ( # noqa: ALN043`
components/customer_health_partner/public/controllers/tests/test_account.py:12 ⧉	`from components.fr.internal.tests.factories.account import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_account.py:15 ⧉	`from components.fr.internal.tests.factories.user import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_customer_metrics.py:5 ⧉	`from components.fr.internal.tests.factories.account import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_customer_metrics.py:8 ⧉	`from components.fr.internal.tests.factories.user import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_customer_priorities_survey.py:13 ⧉	`from components.fr.internal.tests.factories.account import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_customer_priorities_survey.py:16 ⧉	`from components.fr.internal.tests.factories.company import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_customer_priorities_survey.py:19 ⧉	`from components.fr.internal.tests.factories.user import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_pre_renewal_insights.py:5 ⧉	`from components.fr.internal.tests.factories.account import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_pre_renewal_insights.py:8 ⧉	`from components.fr.internal.tests.factories.user import ( # noqa: ALN039,ALN043`
components/customer_health_partner/wellbeing_assessment/external/company_ids_to_account_id.py:10 ⧉	`from components.fr.internal.business_logic.company.queries.company import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/public/commands/wellbeing_assessment.py:16 ⧉	``from components.fr.internal.business_logic.company.queries.company import ( # noqa: ALN043 # will be moved toExternal````
components/customer_health_partner/wellbeing_assessment/public/commands/tests/test_wellbeing_assessment.py:26 ⧉	`from components.fr.internal.tests.factories.company import ( # noqa: ALN043 # - tests`
components/customer_health_partner/wellbeing_assessment/public/commands/tests/test_wellbeing_assessment.py:29 ⧉	`from components.fr.internal.tests.factories.company_admin import ( # noqa: ALN043 # - tests`
components/customer_health_partner/wellbeing_assessment/public/commands/tests/test_wellbeing_assessment.py:32 ⧉	`from components.fr.internal.tests.factories.employment import ( # noqa: ALN043 # - tests`
components/customer_health_partner/wellbeing_assessment/public/commands/tests/test_wellbeing_assessment.py:35 ⧉	`from components.fr.internal.tests.factories.user import ( # noqa: ALN043 # - tests`
components/customer_health_partner/wellbeing_assessment/public/commands/tests/test_common.py:41 ⧉	`from components.fr.internal.tests.factories.company import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/public/controllers/tests/test_generate_wellbeing_assessment_participation_link.py:15 ⧉	`from components.fr.internal.tests.factories.company import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/public/controllers/tests/test_generate_wellbeing_assessment_participation_link.py:18 ⧉	`from components.fr.internal.tests.factories.employment import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/public/controllers/tests/test_wellbeing_assessment_survey.py:11 ⧉	`from components.fr.internal.tests.factories.account import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/public/controllers/tests/test_wellbeing_assessment_survey.py:14 ⧉	`from components.fr.internal.tests.factories.company import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/public/controllers/tests/test_customer_dashboard.py:11 ⧉	`from components.fr.internal.tests.factories.company import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/public/controllers/tests/test_customer_dashboard.py:14 ⧉	`from components.fr.internal.tests.factories.company_admin import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/public/controllers/tests/test_customer_dashboard.py:17 ⧉	`from components.fr.internal.tests.factories.user import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/internal/business_logic/actions/tests/test_assessment.py:41 ⧉	`from components.fr.internal.tests.factories.company import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/internal/business_logic/actions/tests/test_report.py:41 ⧉	`from components.fr.internal.tests.factories.company import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/internal/business_logic/actions/tests/test_launch.py:25 ⧉	`from components.fr.internal.tests.factories.company import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/internal/business_logic/actions/tests/test_launch.py:28 ⧉	`from components.fr.internal.tests.factories.employment import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/internal/business_logic/actions/tests/test_employee_graph.py:20 ⧉	`from components.fr.internal.business_logic.global_customer_dashboard.customer_health_partner import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/internal/business_logic/actions/tests/test_employee_graph.py:23 ⧉	`from components.fr.internal.tests.factories.company import ( # noqa: ALN043`
components/customer_health_partner/wellbeing_assessment/internal/business_logic/queries/tests/test_answers.py:29 ⧉	`from components.fr.internal.tests.factories.company import ( # noqa: ALN043`
components/customer_health_partner/crisis/public/business_logic/actions/tests/test_crisis_request.py:26 ⧉	`from components.fr.internal.tests.factories.account import ( # noqa: ALN043`
components/customer_health_partner/crisis/public/business_logic/queries/tests/test_crisis_request.py:19 ⧉	`from components.fr.internal.tests.factories.account import ( # noqa: ALN043`
components/customer_health_partner/workshops/public/business_logic/actions/workshops_ops_notifications.py:12 ⧉	`from components.fr.internal.helpers.front_end import ( # noqa: ALN043 # explicitly importing the FR config`
components/customer_health_partner/workshops/internal/business_logic/actions/workshops_experts_notifications.py:12 ⧉	`from components.fr.internal.helpers.front_end import ( # noqa: ALN043 # explicitly importing the FR config, to fix later`

ALN039 occurs 13 times¶

File:line	Content
components/customer_health_partner/public/controllers/tests/test_account.py:6 ⧉	`from components.be.internal.models.tests.factories import ( # noqa: ALN039,ALN069`
components/customer_health_partner/public/controllers/tests/test_account.py:9 ⧉	`from components.es.internal.models.tests.factories import ( # noqa: ALN039,ALN069`
components/customer_health_partner/public/controllers/tests/test_account.py:12 ⧉	`from components.fr.internal.tests.factories.account import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_account.py:15 ⧉	`from components.fr.internal.tests.factories.user import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_customer_metrics.py:5 ⧉	`from components.fr.internal.tests.factories.account import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_customer_metrics.py:8 ⧉	`from components.fr.internal.tests.factories.user import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_customer_priorities_survey.py:13 ⧉	`from components.fr.internal.tests.factories.account import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_customer_priorities_survey.py:16 ⧉	`from components.fr.internal.tests.factories.company import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_customer_priorities_survey.py:19 ⧉	`from components.fr.internal.tests.factories.user import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_pre_renewal_insights.py:5 ⧉	`from components.fr.internal.tests.factories.account import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/controllers/tests/test_pre_renewal_insights.py:8 ⧉	`from components.fr.internal.tests.factories.user import ( # noqa: ALN039,ALN043`
components/customer_health_partner/public/business_logic/actions/create_demo_admin_health_partner_features.py:7 ⧉	`from components.fr.internal.models.account import ( # noqa: ALN039,ALN069`
components/customer_health_partner/public/business_logic/actions/create_demo_admin_health_partner_features.py:10 ⧉	`from components.fr.internal.models.user import ( # noqa: ALN039,ALN069`