Code quality
ALN** occurrences by order of importance¶
| NOQA | Number of occurrences |
|---|---|
| ALN069: You can't import models from other components, see: https://www.notion.so/alaninsurance/Modular-monolith-a9d84f1318d34115bbd08b3648e5a587 ⧉", | 8 |
ALN043: You can only import things from a Component public module, see: https://www.notion.so/alaninsurance/Modular-monolith-a9d84f1318d34115bbd08b3648e5a587 ⧉", |
15 |
ALN039: The module public cannot import other components (or from apps/), it's meant to be the public interface of the component #{self.component_name}, see: https://www.notion.so/alaninsurance/Modular-monolith-a9d84f1318d34115bbd08b3648e5a587 ⧉", |
15 |
| ALN037: @property are not serialized by dataclass_json. If not a problem for your use case, please ignore (# noqa: ALN037). "See this Notion page: https://www.notion.so/alaninsurance/Dataclass-the-good-parts-8f387ec2a8e24a55af294237b97dc210#a611a9154af448a38e552c61415169df ⧉ | 1 |
ALN041: As the model '{node.name}' is in a component it must be part of specific schema that is declared in components/{self.component_name}/models/helpers.py", |
1 |
| ALN085: Enforces SQLAlchemy 2.0 query style by detecting deprecated patterns that will be removed in SQLAlchemy 2.0. This linter checks for: 1. Usage of session.query() which is deprecated in favor of session.scalar(), session.scalars(), or session.execute() Note: Other SQLAlchemy 2.0 deprecation warnings are already being turned into errors at runtime by the _turn_sql_alchemy_warning_into_errors function in backend/shared/models/orm/sqlalchemy.py. | 4 |
Listing of files of the most critical ALN**¶
ALN069 occurs 8 times¶
| File:line | Content |
|---|---|
| components/customer_admin/internal/models/be_account_admin.py:9 ⧉ | from components.be.internal.models.be_account import BeAccount # noqa: ALN069 |
| components/customer_admin/internal/models/be_account_admin.py:10 ⧉ | from components.be.internal.models.be_user import BeUser # noqa: ALN069 |
| components/customer_admin/internal/models/fr_company_admin.py:22 ⧉ | from components.fr.internal.models.account import Account # noqa: ALN069 |
| components/customer_admin/internal/models/fr_company_admin.py:23 ⧉ | from components.fr.internal.models.company import Company # noqa: ALN069 |
| components/customer_admin/internal/models/fr_company_admin.py:24 ⧉ | from components.fr.internal.models.user import User # noqa: ALN069 |
| components/customer_admin/internal/models/fr_company_admin.py:25 ⧉ | from components.fr.internal.operational_scopes.models.operational_scope import ( # noqa: ALN069 |
| components/customer_admin/internal/models/be_company_admin.py:17 ⧉ | from components.be.internal.models.be_company import BeCompany # noqa: ALN069 |
| components/customer_admin/internal/models/be_company_admin.py:18 ⧉ | from components.be.internal.models.be_user import BeUser # noqa: ALN069 |
ALN043 occurs 15 times¶
| File:line | Content |
|---|---|
| components/customer_admin/public/actions.py:31 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/actions.py:73 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/actions.py:157 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/actions.py:198 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:38 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:73 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:122 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:183 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:218 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:250 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:313 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:404 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:423 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:471 ⧉ | from components.fr.internal.operational_scopes.business_logic.queries import ( # noqa: ALN043, ALN039 |
| components/customer_admin/internal/business_logic/actions/customer_admin.py:17 ⧉ | from components.ca.internal.customer_dashboard.actions.create_company_admin import ( # noqa: ALN043, ALN039 |
ALN039 occurs 15 times¶
| File:line | Content |
|---|---|
| components/customer_admin/public/actions.py:31 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/actions.py:73 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/actions.py:157 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/actions.py:198 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:38 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:73 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:122 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:183 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:218 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:250 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:313 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:404 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:423 ⧉ | from components.fr.internal.business_logic.global_customer_dashboard.admin import ( # noqa: ALN043, ALN039 |
| components/customer_admin/public/queries.py:471 ⧉ | from components.fr.internal.operational_scopes.business_logic.queries import ( # noqa: ALN043, ALN039 |
| components/customer_admin/internal/business_logic/actions/customer_admin.py:17 ⧉ | from components.ca.internal.customer_dashboard.actions.create_company_admin import ( # noqa: ALN043, ALN039 |