Code quality
ALN** occurrences by order of importance¶
| NOQA | Number of occurrences |
|---|---|
ALN043: You can only import things from a Component public module, see: https://www.notion.so/alaninsurance/Modular-monolith-a9d84f1318d34115bbd08b3648e5a587 ⧉", |
7 |
ALN039: The module public cannot import other components (or from apps/), it's meant to be the public interface of the component #{self.component_name}, see: https://www.notion.so/alaninsurance/Modular-monolith-a9d84f1318d34115bbd08b3648e5a587 ⧉", |
2 |
| ALN027: This class checks that no protected attribute access is used. | 3 |
| ALN085: Enforces SQLAlchemy 2.0 query style by detecting deprecated patterns that will be removed in SQLAlchemy 2.0. This linter checks for: 1. Usage of session.query() which is deprecated in favor of session.scalar(), session.scalars(), or session.execute() Note: Other SQLAlchemy 2.0 deprecation warnings are already being turned into errors at runtime by the _turn_sql_alchemy_warning_into_errors function in backend/shared/models/orm/sqlalchemy.py. | 5 |
Listing of files of the most critical ALN**¶
ALN043 occurs 7 times¶
| File:line | Content |
|---|---|
| components/acuity/public/admin_blueprint.py:7 ⧉ | from components.fr.internal.shareable_features.permissions import ( # noqa: ALN039,ALN043 # this was an helper that could be moved somewhere else |
| components/acuity/public/admin_blueprint.py:79 ⧉ | from components.fr.internal.shareable_features.query import ( # noqa: ALN039,ALN043 # this was an helper that could be moved somewhere else |
| components/acuity/internal/auth.py:4 ⧉ | from components.fr.internal.shareable_features.auth import ( # noqa: ALN043 |
| components/acuity/internal/business_logic/validate_visual_acuity.py:29 ⧉ | from components.fr.internal.business_logic.feature import ( # noqa: ALN043 |
| components/acuity/internal/business_logic/audit.py:15 ⧉ | from components.fr.internal.shareable_features.permissions import ( # noqa: ALN043 |
| components/acuity/internal/business_logic/audit.py:18 ⧉ | from components.fr.internal.shareable_features.query import ( # noqa: ALN043 |
| components/acuity/internal/business_logic/tests/test_audit.py:16 ⧉ | from components.fr.internal.shareable_features.query import QueryPayload # noqa: ALN043 |
ALN039 occurs 2 times¶
| File:line | Content |
|---|---|
| components/acuity/public/admin_blueprint.py:7 ⧉ | from components.fr.internal.shareable_features.permissions import ( # noqa: ALN039,ALN043 # this was an helper that could be moved somewhere else |
| components/acuity/public/admin_blueprint.py:79 ⧉ | from components.fr.internal.shareable_features.query import ( # noqa: ALN039,ALN043 # this was an helper that could be moved somewhere else |